Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unauthenticated SMTP and green status emails #72

Merged
merged 3 commits into from
Mar 7, 2020
Merged

Added unauthenticated SMTP and green status emails #72

merged 3 commits into from
Mar 7, 2020

Conversation

kremerpatrick
Copy link

Allows SMTP_PASSWORD and SMTP_USERNAME to be blank in the JSON config - if both are blank, unauthenticated SMTP on port 25 will be sent.

Added green alarm status for notification when alarm returns to normal.

Adjusted the email body language to match the alarm status.

Signed-off-by: Patrick Kremer pkremer@vmware.com

… - if both are blank, unauthenticated SMTP on port 25 will be sent.

Added green alarm status for notification when alarm returns to normal.

Adjusted the email body language to match the alarm status.

Signed-off-by: Patrick Kremer <pkremer@vmware.com>
Copy link
Contributor

@lamw lamw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes, should be good after that

Patrick Kremer added 2 commits March 6, 2020 23:21
Signed-off-by: Patrick Kremer <pkremer@vmware.com>
Signed-off-by: Patrick Kremer <pkremer@vmware.com>
@lamw lamw merged commit d083a45 into vmware-samples:release-0.3 Mar 7, 2020
@embano1 embano1 added this to the v0.4 Release milestone May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants