Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add greeting action on pull requests #88

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Add greeting action on pull requests #88

merged 1 commit into from
Mar 31, 2020

Conversation

embano1
Copy link
Collaborator

@embano1 embano1 commented Mar 23, 2020

No description provided.

@embano1 embano1 requested a review from lamw March 23, 2020 10:58
@vmwclabot
Copy link

@embano1, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Add greeting action on pull requests
755f524 
Signed-off-by: Michael Gasch <mgasch@vmware.com>
lamw
lamw approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@lamw lamw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lamw lamw merged commit 902e376 into development Mar 31, 2020
@embano1 embano1 deleted the greeting-action branch April 3, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamw lamw lamw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@embano1 @vmwclabot @lamw