Simplify VEBA versioning to support automated Development branch builds

[lamw]

Summary

Please describe your changes and what you plan to introduce as part of this pull request submission. If it fixes a bug or resolves a feature request, be sure to link to the issue numbers following the template below.

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

• Please ensure that you are making a pull request against the Development branch
• Please use the WIP keyword in the title of your PR if you are not ready for review
• Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
• Please ensure that you have signed all commits and that you have squashed all relevant commmits related to your change
• Please make sure that you have tested your change locally by successfully building and deploying the VMware Event Broker Appliance and/or building and deploying VMware Event Router
• Please include any relevant screenshots and/or output as part of your testing
• Please include any documentation updates that is applicable for your changes

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the type of change your PR introduces:

• Bugfix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation changes
• Other (please describe):

Resolved Issues

• Closes Add ability to build VEBA appliance using the development branch of VMware Event Router  #225
• Closes Fix Event Router tag from "0.x.y" to "v0.x.y"  #163

Testing Verification

Successfully built and deployed VEBA Appliance and confirmed all containers are up and endpoints successfully accessible

root@veba [ ~ ]# kubectl get pods -A
NAMESPACE        NAME                                                READY   STATUS      RESTARTS   AGE
kube-system      antrea-agent-89stz                                  2/2     Running     0          8m7s
kube-system      antrea-controller-647fc85df-h67vh                   1/1     Running     0          8m8s
kube-system      coredns-66bff467f8-g4wst                            1/1     Running     0          8m8s
kube-system      coredns-66bff467f8-nl5m7                            1/1     Running     0          8m7s
kube-system      etcd-veba.primp-industries.com                      1/1     Running     0          8m16s
kube-system      kube-apiserver-veba.primp-industries.com            1/1     Running     0          8m16s
kube-system      kube-controller-manager-veba.primp-industries.com   1/1     Running     0          8m16s
kube-system      kube-proxy-z4gwd                                    1/1     Running     0          8m7s
kube-system      kube-scheduler-veba.primp-industries.com            1/1     Running     0          8m16s
openfaas         alertmanager-655465946c-8wdzj                       1/1     Running     0          8m7s
openfaas         basic-auth-plugin-7d4956689b-s4cll                  1/1     Running     0          8m7s
openfaas         faas-idler-b85f98fb7-gcn5c                          1/1     Running     2          8m7s
openfaas         gateway-854d5bf48-rxnj5                             2/2     Running     0          8m7s
openfaas         nats-5cd4dff7c8-s67rr                               1/1     Running     0          8m7s
openfaas         prometheus-859f6bfbc4-78g26                         1/1     Running     0          8m7s
openfaas         queue-worker-6cb888d49c-w2fgf                       1/1     Running     0          8m7s
projectcontour   contour-7676b7794d-9j6lc                            1/1     Running     0          8m7s
projectcontour   contour-7676b7794d-rfkwv                            1/1     Running     0          8m7s
projectcontour   contour-certgen-l9b85                               0/1     Completed   0          8m8s
projectcontour   envoy-nm49b                                         2/2     Running     0          7m56s
vmware           tinywww-6dcd668667-x7g9g                            1/1     Running     0          8m7s
vmware           vmware-event-router-5d79fcf497-xv8r5                1/1     Running     2          8m7s

root@veba [ ~ ]# docker images
REPOSITORY                           TAG                 IMAGE ID            CREATED             SIZE
vmware/veba-event-router             development         2e73623c1c57        4 days ago          117MB
projectcontour/contour               v1.9.0              e5264899280b        7 days ago          38.3MB
envoyproxy/envoy                     v1.15.1             a8b75a4b4116        2 weeks ago         110MB
k8s.gcr.io/kube-proxy                v1.18.3             3439b7546f29        4 months ago        117MB
k8s.gcr.io/kube-controller-manager   v1.18.3             da26705ccb4b        4 months ago        162MB
k8s.gcr.io/kube-scheduler            v1.18.3             76216c34ed0c        4 months ago        95.3MB
k8s.gcr.io/kube-apiserver            v1.18.3             7e28efa976bd        4 months ago        173MB
openfaas/queue-worker                0.11.0              156f3ea15fa6        5 months ago        9.76MB
antrea/antrea-ubuntu                 v0.6.0              36cc5d6d96b8        5 months ago        319MB
projectcontour/contour               v1.4.0              d1cef92ab185        5 months ago        39.5MB
openfaas/faas-netes                  0.10.3              9f1afd1e679c        5 months ago        71.6MB
openfaas/basic-auth-plugin           0.18.17             4d5c7c56e1f4        5 months ago        16.6MB
openfaas/gateway                     0.18.17             9496eadeb6e5        5 months ago        30MB
envoyproxy/envoy                     v1.14.1             d7edcd82b299        6 months ago        169MB
openfaas/faas-idler                  0.3.0               93f8e669f6cf        7 months ago        26.4MB
k8s.gcr.io/pause                     3.2                 80d28bedfe5d        8 months ago        683kB
nats-streaming                       0.17.0              411737a82b95        8 months ago        16MB
k8s.gcr.io/coredns                   1.6.7               67da37a9a360        8 months ago        43.8MB
k8s.gcr.io/etcd                      3.4.3-0             303ce5db0e90        11 months ago       288MB
embano1/tinywww                      latest              4b399f0d56fc        12 months ago       9.71MB
prom/prometheus                      v2.11.0             b97ed892eb23        15 months ago       126MB
prom/alertmanager                    v0.18.0             ce3c87f17369        15 months ago       51.9MB

Additional Information

• N/A

[embano1]

Looks like some commits can be squashed? Also can you please make sure they follow commit naming best practices :) https://chris.beams.io/posts/git-commit/#seven-rules

[embano1]

Nice work! Just some minor comments.

[embano1]

Nice job! LGTM