Add proxy settings to ova #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamw
reviewed
Jan 7, 2020
lamw
reviewed
Jan 7, 2020
lamw
reviewed
Jan 7, 2020
lamw
requested changes
Jan 7, 2020
lamw
reviewed
Jan 15, 2020
lamw
reviewed
Jan 15, 2020
|
I´ve tested all changes locally with proxy settings set and not set. |
- code implemented in the corresponding files - test build created and validated - discovered errors fixed from the review Signed-off-by: Robert Guske <rguske@vmware.com>
|
@lamw @rguske actually that won't suffice since Docker has its own proxy settings that need to be set as well: https://docs.docker.com/config/daemon/systemd/#httphttps-proxy |
|
Thanks for bringing it up @sofixa! I´ll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Guske rguske@vmware.com
Fixes #40
Provides proxy settings to enable the provisioning of VEBA in environments that allows Internet connection through a proxy only. It is also necessary for functions that require an outgoing connection in such environments.