Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate conditional and body in AppConfigValidationFactory.java #5

Merged
merged 1 commit into from
Mar 25, 2016

Conversation

kilida
Copy link
Contributor

@kilida kilida commented Mar 25, 2016

No description provided.

@jessehu
Copy link
Member

jessehu commented Mar 25, 2016

Thanks for the pull request. What do you mean by 'Duplicate conditional body'? I only see 1 poolMaxJobsDefault in the file.

@kilida
Copy link
Contributor Author

kilida commented Mar 25, 2016

Since it's a big chunk, the patch window hides it. It's right above: if you expand the file (or view the entire file) you'll see both:

          } else if ("poolMaxJobsDefault".equals(element.getTagName())) {
             String text = ((Text)element.getFirstChild()).getData().trim();
             try {
                int val = Integer.parseInt(text);
             } catch (NumberFormatException e) {
                validateResult.addFailureValue(text);
             }
-         } else if ("poolMaxJobsDefault".equals(element.getTagName())) {
-            String text = ((Text)element.getFirstChild()).getData().trim();
-            try {
-               int val = Integer.parseInt(text);
-            } catch (NumberFormatException e) {
-               validateResult.addFailureValue(text);
-            }

@jessehu jessehu merged commit 23828ba into vmware-serengeti:master Mar 25, 2016
@jessehu
Copy link
Member

jessehu commented Mar 25, 2016

Thanks @kilida a lot. Looking forward to more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants