Update go version to 1.20.x #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 86.14% 86.14%
=======================================
Files 65 65
Lines 4106 4106
=======================================
Hits 3537 3537
Misses 443 443
Partials 126 126 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shaheerkootteeri
force-pushed
the
version-upgrade
branch
from
7f85866
to
8c71077
Compare
warango4
approved these changes
Mar 16, 2023
odinnordico
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Update go version to 1.20.x in apps-cli. Also updating the CI to run tests on go version 1.20.x.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Validated unit tests as well as integration tests successfully. Installed the app in my local and validated against a local cluster.
Additional information or special notes for your reviewer
The coverage details on integration tests were causing failures with error
error generating coverage report: write /dev/pts/3: file already closed.It is probably due to changes in os/exec package. This pull request removes the covermod from integration tests as it was neither generating a coverage report, nor we are using the report in the CI. Proposing to enhance the coverage report introducing coverage for integration as well as unit tests using the latest features in GO 1.20