Add max log requests for stern tailer #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 86.27% 85.95% -0.32%
==========================================
Files 65 65
Lines 4109 4123 +14
==========================================
- Hits 3545 3544 -1
- Misses 438 453 +15
Partials 126 126
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
With Stern new version (v1.24.0), a new flag was introduced to decide which is the maximum number of concurrent requests. In Apps Plugin code, it never gets to have a default number other than 0, that's why, if not specified in Stern configuration, logs would never appear since there were not available requests to do. A number of the maximum Int16 (32767) was set as the max log requests for Stern, which means there can be up to that amount of pods logging at the same time for Apps Plugin `workload tail` or `workload create/update/apply --tail` to work. Another change introduced in Stern was the `ALL_STATES` option for containers state filter. It was also added in Apps Plugin so all containers are shown (`running,waiting,terminated`). Signed-off-by: Wendy Arango <warango@vmware.com>
odinnordico
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
With Stern new version (v1.24.0), a new flag was introduced to decide which is the maximum number of concurrent requests. In Apps Plugin code, it never gets to have a default number other than 0, that's why, if not specified in Stern configuration, logs would never appear since there weren't any allowed logs to show.
A number of the maximum Int16 (32767) was set as the max log requests for Stern, which means there can be up to that amount of pods logging at the same time for Apps Plugin
workload tailorworkload create/update/apply --tailto work.Another change introduced in Stern was the
ALL_STATESoption for containers state filter. It was also added in Apps Plugin so all containers are shown (running,waiting,terminated).Which issue(s) this PR fixes
Fixes #519
Describe testing done for PR
--tailoption to check that is logging.Additional information or special notes for your reviewer