Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stern latest version (v1.24.0) introduced bugs in Apps Plugin #519

Closed
2 tasks done
warango4 opened this issue Mar 28, 2023 · 0 comments · Fixed by #522
Closed
2 tasks done

Stern latest version (v1.24.0) introduced bugs in Apps Plugin #519

warango4 opened this issue Mar 28, 2023 · 0 comments · Fixed by #522
Assignees
Labels
accepted bug Something isn't working
Milestone

Comments

@warango4
Copy link
Contributor

warango4 commented Mar 28, 2023

Please fill out the issue checklist below and provide ALL the requested information.

  • I reviewed open and closed Github issues that may be related to my problem.
  • I am reporting a bug that others will be able to reproduce.

Describe the bug

Stern released a new version (v1.24.0) which introduced a breaking change that's generating errors in Apps Plugin for --tail flag.
In Apps Plugin v0.11.1, where Stern version was v1.22.0, this error was not happening.

Expected behavior

Do not generate errors coming from Stern when using --tail flag or workload tail command.

Steps to Reproduce

Apply to create or update a workload using tail flag:

tanzu apps workload apply foo --git-repo https://github.com/nycpivot/tanzu-java-web-app  --git-branch main --type web --app tanzu-java-web-app --label apps.tanzu.vmware.com/has-tests=true --tail --yes

🔎 Create workload:
      1 + |---
      2 + |apiVersion: carto.run/v1alpha1
      3 + |kind: Workload
      4 + |metadata:
      5 + |  labels:
      6 + |    app.kubernetes.io/part-of: tanzu-java-web-app
      7 + |    apps.tanzu.vmware.com/has-tests: "true"
      8 + |    apps.tanzu.vmware.com/workload-type: web
      9 + |  name: foo
     10 + |  namespace: default
     11 + |spec:
     12 + |  source:
     13 + |    git:
     14 + |      ref:
     15 + |        branch: main
     16 + |      url: https://github.com/nycpivot/tanzu-java-web-app
👍 Created workload "foo"

To see logs:   "tanzu apps workload tail foo --timestamp --since 1h"
To get status: "tanzu apps workload get foo"

Waiting for workload "foo" to become ready...
Error: stern reached the maximum number of log requests (0), use --max-log-requests to increase the limit

Screenshots

If applicable, add screenshots to help explain your problem.

Version (Apps plugin version, Version of K8s running on cluster)

Put the output of the following commad

tanzu version && tanzu apps version

version: v0.28.0
buildDate: 2023-01-20
sha: 3c34115bc-dirty
v0.11.0+dev-1582864e

Environment where the bug was observed (cloud, OS, etc)

MacOS Ventura 13.2.1

Additional context & Relevant Debug Output (Logs, etc)

Add any other context about the problem here.

@warango4 warango4 added bug Something isn't working needs-triage labels Mar 28, 2023
@warango4 warango4 added this to the 0.12.0 milestone Mar 28, 2023
@warango4 warango4 changed the title Stern new version introduced bugs in Apps Plugin Stern latest version (v1.24.0) introduced bugs in Apps Plugin Mar 28, 2023
@warango4 warango4 self-assigned this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants