feat: Add new command to check local-source-proxy status #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #524 +/- ##
==========================================
- Coverage 85.95% 85.65% -0.31%
==========================================
Files 65 69 +4
Lines 4123 4265 +142
==========================================
+ Hits 3544 3653 +109
- Misses 453 477 +24
- Partials 126 135 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
$ tanzu apps local-source-proxy health
user_has_permission: false
reachable: false
upstream_authenticated: false
overall_health: false
message: -|
The current user does not have permission to access the local source proxy
- services "http:local-source-proxy:5001" is forbidden: User "***@vmware.com" cannot get resource "services/proxy" in API group "" in the namespace "tap-local-source-system": requires one of ["container.services.proxy"] permission(s). |
warango4
reviewed
Apr 10, 2023
|
Please rebase as there is a conflict with main branch |
warango4
reviewed
Apr 10, 2023
Signed-off-by: Wendy Arango <warango@vmware.com> Signed-off-by: Diego Alfonso <dalfonso@vmware.com> Co-authored-by: Wendy Arango <warango@vmware.com> Co-authored-by: Diego Alfonso<dalfonso@vmware.com> Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
warango4
previously approved these changes
Apr 10, 2023
anibmurthy
reviewed
Apr 10, 2023
anibmurthy
reviewed
Apr 10, 2023
anibmurthy
reviewed
Apr 10, 2023
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Although in TAP 1.6+, LSP will be provisioned by default on TAP iterate clusters, we can’t assume developers will always be pointing to a TAP env where LSP exists or is running/healthy.
This PR provides an apps command that can be invoked by the IDE extensions to determine whether LSP is installed/healthy
A new CLI command that checks:
Which issue(s) this PR fixes
Fixes #523
Describe testing done for PR
Testing against installation from the source code of Local Source Proxy, causing the scenarios described in the outputs
Check comment below
Additional information or special notes for your reviewer