fix: handle 2xx status as healthy lsp #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
warango4
approved these changes
Apr 12, 2023
anibmurthy
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Although in TAP 1.6+, LSP will be provisioned by default on TAP iterate clusters, we can’t assume developers will always be pointing to a TAP env where LSP exists or is running/healthy.
This PR fixes the LSP health response validation to take all the 2xx HTTP codes as a healthy answer
Which issue(s) this PR fixes
Fixes #523
Describe testing done for PR
Additional information or special notes for your reviewer