Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a non default service account #130

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Add a non default service account #130

merged 4 commits into from
Jun 7, 2022

Conversation

kkavitha
Copy link
Contributor

@kkavitha kkavitha commented Jun 7, 2022 •
edited by scothis
Loading

Pull request

What this PR does / why we need it

Adding an overlay to add annotation to service account with arn role id for AWS

@kkavitha kkavitha requested a review from scothis June 7, 2022 15:14
scothis
scothis reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@scothis scothis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search/replace went too far, but also missing setting the serviceAccountName on the Deployment for the controller manager.

config/samples/v1alpha1_podintent.yaml Outdated Show resolved Hide resolved
pkg/apis/conventions/v1alpha1/podintent_defaults.go Outdated Show resolved Hide resolved
pkg/apis/conventions/v1alpha1/podintent_test.go Outdated Show resolved Hide resolved
pkg/controllers/podintent_reconciler_test.go Outdated Show resolved Hide resolved
pkg/controllers/podintent_reconciler_test.go Outdated Show resolved Hide resolved
scothis
scothis approved these changes Jun 7, 2022
View reviewed changes
go.work.sum
@@ -1,17 +1,406 @@
4d63.com/gochecknoglobals v0.1.0/go.mod h1:wfdC5ZjKSPr7CybKEcgJhUOgeAQW1+7WcyK8OvUilfo=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect any of the go dependencies to change as part of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, running make dist changes it for me. This happens even on main with the latest commit. I have go 1.18.1 on my system.

config/rbac/service-account.yaml
@@ -0,0 +1,6 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would tend to put this under the manager layer, but it's a bit ambiguous as both layers need to agree on the name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I was going back and forth but the rbac layer had the maximum number of references 😄 I can move it to manager folder

@codecov-commenter
Copy link

Codecov Report

Merging #130 (37be4aa) into main (97f4f98) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   69.48%   69.48%           
=======================================
  Files          17       17           
  Lines         934      934           
=======================================
  Hits          649      649           
  Misses        265      265           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f4f98...37be4aa. Read the comment docs.

@kkavitha kkavitha merged commit fad82d9 into vmware-tanzu:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scothis scothis scothis approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkavitha @codecov-commenter @scothis @vmwclabot