Avoid kapp phantom diff on AKS #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKS injects an additional facet into the namespaceSelector for mutating and validating webhook configurations. The next time kapp deploys the dist, it removes the injected values as drift, and so on in a loop. We can disable the AKS behavior by specifying an annotation `admissions.enforcer/disabled: "true"`. This makes the webhooks behave like on other k8s distributions. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AKS injects an additional facet into the namespaceSelector for mutating
and validating webhook configurations. The next time kapp deploys the
dist, it removes the injected values as drift, and so on in a loop.
We can disable the AKS behavior by specifying an annotation
admissions.enforcer/disabled: "true". This makes the webhooks behavelike on other k8s distributions.
Signed-off-by: Scott Andrews andrewssc@vmware.com