Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use kubebuilder conventions for controllers and webhooks setup (#747)
* Run go mod tidy in hack/tools Co-authored-by: Marty Spiewak <mspiewak@vmware.com> Co-authored-by: Emily Johnson <emjohnson@vmware.com>
- Loading branch information
1 parent
66cd5c1
commit 3aefe09
Showing
43 changed files
with
805 additions
and
1,004 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Copyright 2021 VMware | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook" | ||
| ) | ||
|
|
||
| // +kubebuilder:webhook:path=/validate-carto-run-v1alpha1-clusterconfigtemplate,mutating=false,failurePolicy=fail,sideEffects=none,admissionReviewVersions=v1beta1;v1,groups=carto.run,resources=clusterconfigtemplates,verbs=create;update,versions=v1alpha1,name=config-template-validator.cartographer.com | ||
|
|
||
| var _ webhook.Validator = &ClusterConfigTemplate{} | ||
|
|
||
| func (c *ClusterConfigTemplate) ValidateCreate() error { | ||
| return c.Spec.TemplateSpec.validate() | ||
| } | ||
|
|
||
| func (c *ClusterConfigTemplate) ValidateUpdate(_ runtime.Object) error { | ||
| return c.Spec.TemplateSpec.validate() | ||
| } | ||
|
|
||
| func (c *ClusterConfigTemplate) ValidateDelete() error { | ||
| return nil | ||
| } | ||
|
|
||
| func (c *ClusterConfigTemplate) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewWebhookManagedBy(mgr). | ||
| For(c). | ||
| Complete() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| // Copyright 2021 VMware | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "k8s.io/apimachinery/pkg/runtime" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook" | ||
| ) | ||
|
|
||
| // +kubebuilder:webhook:path=/validate-carto-run-v1alpha1-clusterdeploymenttemplate,mutating=false,failurePolicy=fail,sideEffects=none,admissionReviewVersions=v1beta1;v1,groups=carto.run,resources=clusterdeploymenttemplates,verbs=create;update,versions=v1alpha1,name=deployment-template-validator.cartographer.com | ||
|
|
||
| var _ webhook.Validator = &ClusterDeploymentTemplate{} | ||
|
|
||
| func (c *ClusterDeploymentTemplate) ValidateCreate() error { | ||
| return c.validate() | ||
| } | ||
|
|
||
| func (c *ClusterDeploymentTemplate) ValidateUpdate(_ runtime.Object) error { | ||
| return c.validate() | ||
| } | ||
|
|
||
| func (c *ClusterDeploymentTemplate) ValidateDelete() error { | ||
| return nil | ||
| } | ||
|
|
||
| func (c *ClusterDeploymentTemplate) validate() error { | ||
| err := c.Spec.TemplateSpec.validate() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if c.bothConditionsSet() || c.neitherConditionSet() { | ||
| return fmt.Errorf("invalid spec: must set exactly one of spec.ObservedMatches and spec.ObservedCompletion") | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (c *ClusterDeploymentTemplate) bothConditionsSet() bool { | ||
| return c.Spec.ObservedMatches != nil && c.Spec.ObservedCompletion != nil | ||
| } | ||
|
|
||
| func (c *ClusterDeploymentTemplate) neitherConditionSet() bool { | ||
| return c.Spec.ObservedMatches == nil && c.Spec.ObservedCompletion == nil | ||
| } | ||
|
|
||
| func (c *ClusterDeploymentTemplate) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewWebhookManagedBy(mgr). | ||
| For(c). | ||
| Complete() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // Copyright 2021 VMware | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package v1alpha1 | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/webhook" | ||
| ) | ||
|
|
||
| // +kubebuilder:webhook:path=/validate-carto-run-v1alpha1-clusterimagetemplate,mutating=false,failurePolicy=fail,sideEffects=none,admissionReviewVersions=v1beta1;v1,groups=carto.run,resources=clusterimagetemplates,verbs=create;update,versions=v1alpha1,name=image-template-validator.cartographer.com | ||
|
|
||
| var _ webhook.Validator = &ClusterImageTemplate{} | ||
|
|
||
| func (c *ClusterImageTemplate) ValidateCreate() error { | ||
| return c.Spec.TemplateSpec.validate() | ||
| } | ||
|
|
||
| func (c *ClusterImageTemplate) ValidateUpdate(_ runtime.Object) error { | ||
| return c.Spec.TemplateSpec.validate() | ||
| } | ||
|
|
||
| func (c *ClusterImageTemplate) ValidateDelete() error { | ||
| return nil | ||
| } | ||
|
|
||
| func (c *ClusterImageTemplate) SetupWebhookWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewWebhookManagedBy(mgr). | ||
| For(c). | ||
| Complete() | ||
| } |
Oops, something went wrong.