Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kubebuilder conventions for controllers and webhooks setup #747

Merged
merged 1 commit into from Mar 29, 2022
Merged

Use kubebuilder conventions for controllers and webhooks setup #747

merged 1 commit into from Mar 29, 2022

Conversation

martyspiewak
Copy link
Contributor

Co-authored-by: Emily Johnson emjohnson@vmware.com

Changes proposed by this PR

  • Refactor the way we setup our controllers and webhooks to follow kubebuilder convetions.

closes #465

Release Note

PR Checklist

Note: Please do not remove items. Mark items as done [x] or use strikethrough if you believe they are not relevant

  • Linked to a relevant issue. Eg: Fixes #123 or Updates #123
  • Removed non-atomic or wip commits
  • Filled in the Release Note section above
  • Modified the docs to match changes

@netlify
Copy link

netlify bot commented Mar 25, 2022 •
edited

✅ Deploy Preview for elated-stonebraker-105904 ready!

Name Link
🔨 Latest commit 84ec8b9
🔍 Latest deploy log https://app.netlify.com/sites/elated-stonebraker-105904/deploys/624315f78be5100008dbf6b2
😎 Deploy Preview https://deploy-preview-747--elated-stonebraker-105904.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

idoru
idoru requested changes Mar 25, 2022
View reviewed changes
pkg/cmd/cmd.go Show resolved Hide resolved
@martyspiewak martyspiewak force-pushed the more-kubebuilder branch 2 times, most recently from 0e5943f to 943c28e Compare March 28, 2022 17:55
cirocosta
cirocosta reviewed Mar 28, 2022
View reviewed changes
pkg/cmd/cmd.go Outdated Show resolved Hide resolved
cirocosta
cirocosta reviewed Mar 28, 2022
View reviewed changes
pkg/utils/unhandled.go Outdated Show resolved Hide resolved
cirocosta
cirocosta approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@cirocosta cirocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just left some minor comments 👍

@martyspiewak martyspiewak enabled auto-merge (squash) March 29, 2022 14:18
@emmjohnson
Use kubebuilder conventions for controllers and webhooks setup
84ec8b9 
* Run go mody tidy in hack/tools

Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
@martyspiewak martyspiewak enabled auto-merge (squash) March 29, 2022 14:22
@martyspiewak martyspiewak merged commit 3aefe09 into main Mar 29, 2022
@martyspiewak martyspiewak deleted the more-kubebuilder branch March 29, 2022 14:39
@martyspiewak martyspiewak mentioned this pull request Mar 29, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoru idoru idoru approved these changes

@cirocosta cirocosta cirocosta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make our setup consistent with kube-builder conventions
4 participants
@martyspiewak @idoru @cirocosta @emmjohnson