config: remove placeholder secret #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make the installation of Cartographer in carvel-based packaging easier, we used to have this secret that gets filled by secretgen-controller as part of the set of objects shipped in the release, but given that it's such a packaging-specific detail, here we get rid of it favoring `package-for-cartographer` as the location for doing so. see vmware-tanzu/package-for-cartographer#23 for the PR where that addition of a secret to the package takes place (file: src/cartographer/config/overlays/image-pull-secret.yaml) Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
✅ Deploy Preview for elated-stonebraker-105904 canceled.
|
when installing cartographer, such object is not included anymore, so it wouldn't show up in the list of objects that kapp is managing Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
|
done |
added 4 commits
April 6, 2022 21:07
any carvel packaging related to cartographer now takes place under `vmware-tanzu/package-for-cartographer`, so, get rid of this leftover. Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
we used to bring up the registry with authentication enabled so that we could be sure that the packaging work was right w/ regards to providing credentials via secretgen's placeholder secrets, but now that such responsability has shifted towards the packaging efforts under `vmware-tanzu/package-for-cartographer`, we can now get rid of this requirement from this repository Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
with the registry used by those not requiring any more auth, we can get rid of those credentials from the setup. Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
with the removal of the need for authenticating against the registry where we publish the release of cartographer, we can now skip all the references to the previously `hack/registry-auth` directory where a secretexport was placed for the credentials to the local registry Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
scothis
reviewed
Apr 7, 2022
Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
martyspiewak
approved these changes
Apr 7, 2022
scothis
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
in order to make the installation of Cartographer in carvel-based
packaging easier, we used to have this secret that gets filled by
secretgen-controller as part of the set of objects shipped in the
release, but given that it's such a packaging-specific detail, here we
get rid of it favoring
package-for-cartographeras the location fordoing so.
see vmware-tanzu/package-for-cartographer#23 for
the PR where that addition of a secret to the package takes place (file:
src/cartographer/config/overlays/image-pull-secret.yaml)
Release Note
PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits