Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove placeholder secret #793

Merged
merged 7 commits into from
Apr 7, 2022
Merged

Commits on Apr 6, 2022

  1. config: remove placeholder secret

    in order to make the installation of Cartographer in carvel-based
    packaging easier, we used to have this secret that gets filled by
    secretgen-controller as part of the set of objects shipped in the
    release, but given that it's such a packaging-specific detail, here we
    get rid of it favoring `package-for-cartographer` as the location for
    doing so.
    
    see vmware-tanzu/package-for-cartographer#23 for
    the PR where that addition of a secret to the package takes place (file:
    src/cartographer/config/overlays/image-pull-secret.yaml)
    
    Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
    Ciro S. Costa committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3233a33 View commit details
    Browse the repository at this point in the history
  2. docs: remove placeholder secret

    when installing cartographer, such object is not included anymore, so it
    wouldn't show up in the list of objects that kapp is managing
    
    Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
    Ciro S. Costa committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fac5aee View commit details
    Browse the repository at this point in the history
  3. packaging: remove everything packaging related

    any carvel packaging related to cartographer now takes place under
    `vmware-tanzu/package-for-cartographer`, so, get rid of this leftover.
    
    Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
    Ciro S. Costa committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e1549fe View commit details
    Browse the repository at this point in the history
  4. hack: remove registry authentication

    we used to bring up the registry with authentication enabled so that we
    could be sure that the packaging work was right w/ regards to providing
    credentials via secretgen's placeholder secrets, but now that such
    responsability has shifted towards the packaging efforts under
    `vmware-tanzu/package-for-cartographer`, we can now get rid of this
    requirement from this repository
    
    Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
    Ciro S. Costa committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fb3006c View commit details
    Browse the repository at this point in the history
  5. hack: remove registry creds from examples setup

    with the registry used by those not requiring any more auth, we can get
    rid of those credentials from the setup.
    
    Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
    Ciro S. Costa committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    cafe909 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. hack: remove references to registry-auth

    with the removal of the need for authenticating against the registry
    where we publish the release of cartographer, we can now skip all the
    references to the previously `hack/registry-auth` directory where a
    secretexport was placed for the credentials to the local registry
    
    Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
    Ciro S. Costa committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    961bd40 View commit details
    Browse the repository at this point in the history
  2. hack: add back registry startup log

    Signed-off-by: Ciro S. Costa <ciroscosta@vmware.com>
    Ciro S. Costa committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    c8d1060 View commit details
    Browse the repository at this point in the history