This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Add E2E test for Chocolatey package for PR changes #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test checks - TCE installation - TCE uninstallation Signed-off-by: Karuppiah Natarajan <karuppiahn@vmware.com>
github-actions
bot
added
the
owner/release-eng
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes #2229
The test checks
Details for the Release Notes
Which issue(s) this PR fixes
Fixes: #2229
Describe testing done for PR
Sample pipelines testing the script are here -
https://github.com/karuppiah7890/community-edition/runs/3881589631
https://github.com/karuppiah7890/community-edition/runs/3871557248
Special notes for your reviewer
I have some more ideas to improve this E2E test. Let me know what you folks think -
packpush.ps1, we can add a feature to override the local directory it pushes the chocolatey package to. Currently it pushes to one directory -community-edition/hack/choco/packpush.ps1
Line 18 in 5ac772b
${HOME}\tce-pkgas a default and allow overrides. With the directory path override feature in place, in the E2E tests we can use a temporary directory to push the chocolatey package to and use that temporary directory for installation too. This can keep the E2E test related files in a separate place not affecting the user's / developer's workflow of using${HOME}\tce-pkgby default for their manual testing etc.