Liveness and Readiness Probe PR is broken.

[zaggash]

What steps did you take and what happened:
Updating the Charts in place and the application failed to start.

The PR 90450f6 assume you have metrics enabled.

What did you expect to happen:

The update should run but not affect my workload.

The output of the following commands will help us better understand what's going on:
My pod is starting but failling because of :

Messages
• Readiness probe errored: strconv.Atoi: parsing "http-monitoring": invalid syntax

Anything else you would like to add:
The probe uses the metrics endpoint.
However if you have metrics disabled, the liveness config is not valid.

Environment:

• helm version (use helm version): 3.12.0
• helm chart version and app version (use helm list -n <YOUR NAMESPACE>): 4.1.0
• Kubernetes version (use kubectl version): 1.27.2
• Kubernetes installer & version: k3s 1.27.2+k3s1
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release): FlatCar 3374.2.1

[jenting]

@maxime1907 could you please help address this issue?

[sjoukedv]

The new default probe is only valid if you have metrics.enabled (see https://github.com/vmware-tanzu/helm-charts/blob/main/charts/velero/templates/deployment.yaml#L70-74).

#470 solves the issue I am having, but in the ideal world we would automatically set the liveness/readiness probe on the container for those that do have metric enabled

[zaggash]

You mean #471 not this issue #470

right ?

[sjoukedv]

Yes, my bad. That's also the one where this issue was referenced.