[velero] probes only when metrics are enabled

[maxime1907]

Special notes for your reviewer:

Fixes #470

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the values.yaml or README.md
• Title of the PR starts with chart name (e.g. [velero])

[jenting]

I think we should add

{{- if .Values.metrics.enabled }}
{{- end }}

between

helm-charts/charts/velero/templates/deployment.yaml

Lines 157 to 163 in 90450f6

	{{- with .Values.livenessProbe }}
	livenessProbe: {{- toYaml . | nindent 12 }}
	{{- end }}
	{{- with .Values.readinessProbe }}
	readinessProbe: {{- toYaml . | nindent 12 }}
	{{- end }}
	{{- with .Values.containerSecurityContext }}

[maxime1907]

@jenting its done!

[jenting]

@maxime1907 Given the http-monitoring is valid when .Values.metrics.enabled = true

helm-charts/charts/velero/templates/deployment.yaml

Lines 70 to 74 in 90450f6

	{{- if .Values.metrics.enabled }}
	ports:
	- name: http-monitoring
	containerPort: 8085
	{{- end }}

So, we should change the deployment.yaml to

          {{- if .Values.metrics.enabled }}
          {{- with .Values.livenessProbe }}
          livenessProbe: {{- toYaml . | nindent 12 }}
          {{- end }}
          {{- with .Values.readinessProbe }}
          readinessProbe: {{- toYaml . | nindent 12 }}
          {{- end }}
          {{- end }}

[maxime1907]

@jenting is it ok now ?

[jenting]

We don't need to change the values.yaml anymore.

[maxime1907]

@jenting done!

[jenting]

Thank you 😊