-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velero] Bump velero version to v1.7.0 #311
Conversation
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
- /tmp/sh | ||
args: | ||
- -c | ||
- kubectl apply -f /tmp/crds.yaml | ||
{{- with .Values.kubectl.resources }} | ||
- /velero install --crds-only --dry-run -o yaml | /tmp/kubectl apply -f - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the sh
or kubectl
is required anymore, I was able to get this to work in our cluster by just running velero install --crds-only
, it uses the same credentials that kubectl apply
would be using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion.
But the velero install --crds-only
only applies when the CRD resource does not exist.
Velero won't apply the patch/put change when the CRD resource exists already. Ref to code.
Therefore, if the user upgrades from the old Velero version to the new Velero version, after successfully update, the CRD resource is still the old Velero version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the help text of the --crds-only
argument ("Useful for updating CRDs for an existing Velero install.") had me confused, and I didn't realise that it failed 🤦🏻♀️
Filed a ticket about the help text: vmware-tanzu/velero#4236
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Bump? We're keen to deploy distroless Velero, and we use these charts. |
Signed-off-by: JenTing Hsiao <jenting.hsiao@suse.com>
Special notes for your reviewer:
Since from v1.7.0, the velero container image a distroless, there is no shell command anymore.
We leverage the
bitnami/kubectl
in theinitContainer
phase, copy thesh
andkubectl
command to/tmp
folder.After that, the velero container is able to use the
sh
(pipe redirection) andkubectl
command to upgrade the CRDs by shared mount point/tmp
with commandNote that: we deprecate the
kubectl.initResources
and use.resources
instead since the Velero container image CPU/Memory request/limit should be the same as Velero Deployment.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero]
)