New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for secret env vars #99
Conversation
eee7b23
to
7da76b5
Compare
Signed-off-by: Kévin Dunglas <dunglas@gmail.com>
Signed-off-by: Kévin Dunglas <dunglas@gmail.com>
0ec34f1
to
957bbda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm!
@skriss should this also go on therestic-daemonset
template?
@carlisia yeah, I think it probably should, since the secret is mounted in there too so presumably any extra env vars apply there as well. |
Ok @dunglas, please also add it to the |
Signed-off-by: Kévin Dunglas <dunglas@gmail.com>
521543a
to
b06a092
Compare
@carlisia done! Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, and thanks for adding .Values.configuration.extraEnvVars
to the restic template too!
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR @dunglas!
Hello.
What is For configuration: credentials:
existingSecret: velero-secrets
extraEnvVars:
DIGITALOCEAN_TOKEN: 'hello' Need generate 2 secrets: Because is generate: - name: DIGITALOCEAN_TOKEN
valueFrom:
secretKeyRef:
name: velero
key: DIGITALOCEAN_TOKEN |
In deployment.yaml file on line 129 under secretKeyRef
should have been
|
This PR adds a new value
credentials.extraEnvVars
allowing to store data in a secret and expose it to the container through an environment variable.This is necessary for the Digital Ocean plugin and maybe other.
I tested it (and it works). This PR also includes #94 (because without this PR, the chart is broken). I'll rebase when #94 will be merged.
Thanks for this great tool by the way!