Skip to content

Commit

Permalink
fix flux plugin UpdateInstalledPackage() according to agreed upon sem…
Browse files Browse the repository at this point in the history
…antics (#3468)

* step 1

* step 2

* step 3

* step 4

* step 5

* step 6

* step 6

* Michael feedback #1

* Michael's feedback #1a
  • Loading branch information
gfichtenholt committed Sep 22, 2021
1 parent 3962caf commit 6dca124
Show file tree
Hide file tree
Showing 20 changed files with 2,085 additions and 1,572 deletions.
12 changes: 6 additions & 6 deletions cmd/kubeapps-apis/docs/kubeapps-apis.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@
"PackagesService"
]
},
"patch": {
"put": {
"operationId": "PackagesService_UpdateInstalledPackage",
"responses": {
"200": {
Expand Down Expand Up @@ -963,7 +963,7 @@
"FluxV2PackagesService"
]
},
"patch": {
"put": {
"summary": "UpdateInstalledPackage updates an installed package based on the request.",
"operationId": "FluxV2PackagesService_UpdateInstalledPackage",
"responses": {
Expand Down Expand Up @@ -1505,7 +1505,7 @@
"HelmPackagesService"
]
},
"patch": {
"put": {
"summary": "UpdateInstalledPackage updates an installed package based on the request.",
"operationId": "HelmPackagesService_UpdateInstalledPackage",
"responses": {
Expand Down Expand Up @@ -2004,7 +2004,7 @@
"KappControllerPackagesService"
]
},
"patch": {
"put": {
"summary": "UpdateInstalledPackage updates an installed package based on the request.",
"operationId": "KappControllerPackagesService_UpdateInstalledPackage",
"responses": {
Expand Down Expand Up @@ -2931,7 +2931,7 @@
},
"pkgVersionReference": {
"$ref": "#/definitions/v1alpha1VersionReference",
"title": "For helm this will be the exact version in VersionReference.version\nFor other plugins we can extend the VersionReference as needed. Optional"
"title": "For helm this will be the exact version in VersionReference.version\nFor fluxv2 this could be any semver constraint expression\nFor other plugins we can extend the VersionReference as needed. Optional"
},
"values": {
"type": "string",
Expand All @@ -2942,7 +2942,7 @@
"description": "An optional field for specifying data common to systems that reconcile\nthe package on the cluster."
}
},
"description": "Request for UpdateInstalledPackage. Partial resource updates are supported.\nFor example, to change the package version one only needs to specify the version reference.\nSimilarly to update the values, one only needs to specify that field",
"description": "Request for UpdateInstalledPackage. The intent is to reach the desired state specified\nby the fields in the request, while leaving other fields intact. This is a whole \nobject \"Update\" semantics rather than \"Patch\" semantics. The caller will provide the \nvalues for the fields fields below, which will replace, or be overlayed onto, the \ncorresponding fields in the existing resource. For example, with the\nUpdateInstalledPackageRequest, it is not possible to change just the 'package version \nreference' without also specifying 'values' field. As a side effect, not specifying the \n'values' field in the request means there are no values specified in the desired state. \nSo the meaning of each field value is describing the desired state of the corresponding \nfield in the resource after the update operation has completed the renconciliation.",
"title": "UpdateInstalledPackageRequest"
},
"v1alpha1UpdateInstalledPackageResponse": {
Expand Down
2 changes: 1 addition & 1 deletion cmd/kubeapps-apis/gen/apidocs.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 13 additions & 5 deletions cmd/kubeapps-apis/gen/core/packages/v1alpha1/packages.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cmd/kubeapps-apis/gen/core/plugins/v1alpha1/plugins.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6dca124

Please sign in to comment.