Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first run of kubeapps up/down #1

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Oct 27, 2017

This is the first shape of $ kubeapps up/down.

  • For testing purpose, kubeapps will read yaml files at $HOME/.kubeapps directory and deploy them to k8s. Thus, we can easily update/replace manifests.
  • Support KUBECONFIG env (default to ~/.kube/config)
  • Support --dry-run
  • Support --namespace (default to api.NamespaceDefault)

Building

$ go build kubeapps -o main.go

Usage

$ kubeapps up
$ kubeapps down
// update manifests
$ kubeapps up

@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 27, 2017

Please note to review commit each. There is a commit for vendorup that will destroy your browser.

@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 27, 2017

I should merge it directly to have a good shape of the repo. We'll work later on further PRs.

@ngtuna ngtuna merged commit 46f755b into vmware-tanzu:master Oct 27, 2017
@andresmgot
Copy link
Contributor

Sorry, I didn't have the time to take a look to this. Two comments:

  • I think we should maintain a list of stuff to install rather than trying to install indiscriminately the things present in the manifest folder. That way it would be easier to handle partial installations/uninstallation.
  • My advice is to start writing test as soon as possible (as far as the implementation is validated). You should test the current behavior and the possible inputs/outputs. Plus the functions in root.go (mostly getHome, buildOutOfClusterConfig, and parseObjects) would benefit from unit tests.

arapulido pushed a commit to arapulido/kubeapps that referenced this pull request Feb 13, 2018
prydonius pushed a commit that referenced this pull request Feb 23, 2018
Bash away at travis config until it passes
prydonius added a commit that referenced this pull request Feb 23, 2018
nginx-ingress-controller now runs in kubeapps namespace
prydonius added a commit to prydonius/kubeapps that referenced this pull request Feb 28, 2018
prydonius added a commit to prydonius/kubeapps that referenced this pull request Mar 12, 2018
triggers a Job to run an immediate initial sync
@migmartri migmartri mentioned this pull request Sep 13, 2018
gfichtenholt referenced this pull request in gfichtenholt/kubeapps Aug 10, 2021
gfichtenholt added a commit that referenced this pull request Aug 10, 2021
* step 1

* step 2

* step 4

* step 5

* step 6

* step 7

* step 8

* step 9

* step 9b

* step 10

* Michael's feedback #1
gfichtenholt referenced this pull request in gfichtenholt/kubeapps Sep 2, 2021
gfichtenholt added a commit that referenced this pull request Sep 2, 2021
…entation (#3337)

* add a check at bootstrap that flux is installed

* fix up .protos for CreateInstalledPackage API

* intermediate step

* intermediate step 2

* remove files from PR that I didn't modify

* michael's feedback #1

* michael's feedback #2
gfichtenholt referenced this pull request in gfichtenholt/kubeapps Sep 13, 2021
gfichtenholt added a commit that referenced this pull request Sep 13, 2021
…t for CreateInstalledPackage (#3390)

* introduce a new kind of test: one that runs on a local kind cluster

* step 2

* step 3: TestKindClusterCreateInstalledPackage passing

* step 4

* step 5

* step 6: get rid of dependency on flux CLI

* step 7: get rid of dependency on kubectl CLI

* step 8: added back unit tests for CreateInstalledPackage

* step 9

* step 10: support values

* step 11: eliminate dependency on github.io in integration test (1 of 2)

* Michael's feedback #1

* Michael's feedback #2
gfichtenholt referenced this pull request in gfichtenholt/kubeapps Sep 22, 2021
gfichtenholt added a commit that referenced this pull request Sep 22, 2021
…antics (#3468)

* step 1

* step 2

* step 3

* step 4

* step 5

* step 6

* step 6

* Michael feedback #1

* Michael's feedback #1a
gfichtenholt referenced this pull request in gfichtenholt/kubeapps Oct 26, 2021
gfichtenholt added a commit that referenced this pull request Oct 27, 2021
* step 1

* step 2

* step 3

* step 4

* Michael's feedback #1
gfichtenholt referenced this pull request in gfichtenholt/kubeapps Mar 21, 2022
gfichtenholt added a commit that referenced this pull request Mar 22, 2022
… similar core interface to packages API. #3496  (#4476)

* attempt #2

* checkpoint #1

* 2nd checkpoint

* Michael's feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants