Skip to content

Commit

Permalink
Merge pull request #1 from anguslees/pr-22
Browse files Browse the repository at this point in the history
nginx-ingress-controller now runs in kubeapps namespace
  • Loading branch information
prydonius committed Nov 28, 2017
2 parents 408d289 + ce6c6d2 commit c2f2482
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ script:
kubecfg validate -v kubeapps.jsonnet || :
- ./kubeapps.sh up
# We can't port-forward in Travis, so instead we patch the service type to node port
- kubectl patch -n kube-system svc nginx-ingress -p '{"spec":{"type":"NodePort"}}' && sleep 5
- ./tests.sh $(minikube service --namespace kube-system nginx-ingress --url)
- kubectl patch -n kubeapps svc nginx-ingress -p '{"spec":{"type":"NodePort"}}' && sleep 5
- ./tests.sh $(minikube service --namespace kubeapps nginx-ingress --url)

after_success:
- kubectl get all --all-namespaces
Expand Down
6 changes: 3 additions & 3 deletions kubeapps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ case "$subcommand" in
kubectl rollout status -n kubeapps deployment/kubeapps-dashboard-ui
# FIXME: We don't wait for the API to rollout as it times out
# kubectl rollout status -n kubeapps deployment/kubeapps-dashboard-api
kubectl rollout status -n kube-system deployment/nginx-ingress-controller
kubectl rollout status -n kubeapps deployment/nginx-ingress-controller
;;
down)
# This assumes kubeapps.jsonnet is in sync with what's
Expand All @@ -46,9 +46,9 @@ case "$subcommand" in
exec kubecfg show kubeapps.jsonnet "$@"
;;
dashboard)
podname=$(kubectl get pods --namespace kube-system -l name=nginx-ingress-controller -o jsonpath="{.items[0].metadata.name}")
podname=$(kubectl get pods --namespace kubeapps -l name=nginx-ingress-controller -o jsonpath="{.items[0].metadata.name}")
echo "Visit http://localhost:8002 in your browser"
exec kubectl port-forward --namespace kube-system "$podname" 8002:80
exec kubectl port-forward --namespace kubeapps "$podname" 8002:80
;;
*)
echo "Unknown subcommand: $subcommand" >&2
Expand Down

0 comments on commit c2f2482

Please sign in to comment.