Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused chart value allowNamespaceDiscovery #5422

Closed
castelblanque opened this issue Oct 3, 2022 · 5 comments
Closed

Remove unused chart value allowNamespaceDiscovery #5422

castelblanque opened this issue Oct 3, 2022 · 5 comments
Labels
component/packages Issue related to kubeapps packaging formats to be distributed (Helm chart and Carvel packages) good first issue kind/bug An issue that reports a defect in an existing feature
Milestone
Technical debt

Comments

@castelblanque
Copy link
Collaborator

Description
Chart values and Readme file contain a parameter that is not used in any place: allowNamespaceDiscovery.
Please check this repo search.
This could be misleading and frustrating for end users, so let's better remove it.

Acceptance criteria

  • Chart value allowNamespaceDiscovery is removed and not present in values file nor Readme.
@castelblanque castelblanque added kind/bug An issue that reports a defect in an existing feature good first issue component/packages Issue related to kubeapps packaging formats to be distributed (Helm chart and Carvel packages) labels Oct 3, 2022
@antgamdia
Copy link
Contributor

Note that this change can be directly performed at https://github.com/bitnami/charts

@amoghrajesh
Copy link

@castelblanque @antgamdia I would like to work on this as a part of hacktoberfest 2022. Is this repo a part of it?

@ppbaena
Copy link
Collaborator

ppbaena commented Oct 6, 2022

Hi @amoghrajesh , we have labelled the repo and issue so you can participate in hacktoberfest 2022 working on this issue.

@ppbaena ppbaena added this to the Technical debt milestone Oct 6, 2022
@giulianopz giulianopz mentioned this issue Oct 26, 2022
Merged
antgamdia pushed a commit that referenced this issue Oct 29, 2022
@giulianopz
rm chart value 'allowNamespaceDiscovery' fixing issue #5422 (#5574)
d20d2b2 
Fix issue #5422.

Signed-off-by: giuliano <panzironi.giuliano@gmail.com>
@ppbaena ppbaena removed the next-iteration Issues to be discussed in planning session label Nov 21, 2022
@briancbarrow
Copy link

I'm guessing this can be closed since #5574 was merged?

@ppbaena ppbaena closed this as completed Feb 9, 2023
@ppbaena
Copy link
Collaborator

ppbaena commented Feb 9, 2023

Thanks for the heads up @briancbarrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/packages Issue related to kubeapps packaging formats to be distributed (Helm chart and Carvel packages) good first issue kind/bug An issue that reports a defect in an existing feature
Projects
Kubeapps
Archived in project
Milestone
Technical debt
Development

No branches or pull requests
5 participants
@ppbaena @antgamdia @briancbarrow @amoghrajesh @castelblanque