Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository UI - the edit dialog does not allow one to update credentials #5745

Closed
dlaloue-vmware opened this issue Nov 28, 2022 · 0 comments
Closed

Repository UI - the edit dialog does not allow one to update credentials #5745

dlaloue-vmware opened this issue Nov 28, 2022 · 0 comments
Assignees
@dlaloue-vmware
Labels
component/apprepository Issue related to kubeapps apprepository kind/bug An issue that reports a defect in an existing feature
Milestone
Technical debt

Comments

@dlaloue-vmware
Copy link
Collaborator

Describe the bug
After creating a repository with authentication, click edit to change the configuration. The UI does not allow for the authentication information to be updated.
This is an issue if users must update the password for example.

Expected behavior
Users should be able to update credentials information, especially in case the backend password has been updated (e.g. password rotation etc...)

Desktop (please complete the following information):
Kubeapps version 12.1.1/2.6.1
@dlaloue-vmware dlaloue-vmware added the kind/bug An issue that reports a defect in an existing feature label Nov 28, 2022
@dlaloue-vmware dlaloue-vmware self-assigned this Nov 29, 2022
@dlaloue-vmware dlaloue-vmware mentioned this issue Dec 6, 2022
Merged
dlaloue-vmware added a commit that referenced this issue Dec 15, 2022
@dlaloue-vmware
[repository] fixes and enhancements for repository update support (#5763
ed020ef 
)

### Description of the change

This PR contains changes for two purposes:
 - improve feature parity between plugins
 - enable update support in UI

Feature parity:
 - flux: description support
 - flux: support changing to/from auth provider 
 - carvel: description support
 - carvel: support changing auth type 

Bug fixes to support update support in UI:
 - auth updates were not possible
 - fixed conditions for fields enablement
- form fields data were sent incorrectly as a group, instead of only
sending what applied
 - errors handling 'undefined' values
 - fixed which auth types are valid per plugin+type combination
 - fixed issue with helm plugins image pull secrets

helm/flux bug fixes:
- fixed handling of redacted fields leading to secrets not being updated
as expected or secret data being overwritten with 'redacted' as value.

(note: the PR has many small changes, but i was fixing issues as i was
testing, hence the list)


### Benefits

With the changes, users should see more commonality between plugin
features, as well as a more robust UI experience regarding repository
creation/updates.


### Applicable issues

fixes issues #5745, #5746 and #5747


### Additional information

The issue 1 in # 5746 could not be reproduce with the latest bits, so no
change were made for it.
@ppbaena ppbaena added the component/apprepository Issue related to kubeapps apprepository label Dec 19, 2022
@ppbaena ppbaena added this to the Technical debt milestone Dec 19, 2022
@ppbaena ppbaena closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlaloue-vmware dlaloue-vmware

Labels
component/apprepository Issue related to kubeapps apprepository kind/bug An issue that reports a defect in an existing feature
Projects
Kubeapps
Archived in project
Milestone
Technical debt
Development

No branches or pull requests
2 participants
@ppbaena @dlaloue-vmware