helm repository - some auth updates are ignored or lost #5746
Assignees
Labels
component/plugin-helm
Issue related to kubeapps plugin to manage Helm packages
kind/bug
An issue that reports a defect in an existing feature
Milestone
Comments
dlaloue-vmware
added
the
kind/bug
dlaloue-vmware
added a commit
that referenced
this issue
Dec 15, 2022
) ### Description of the change This PR contains changes for two purposes: - improve feature parity between plugins - enable update support in UI Feature parity: - flux: description support - flux: support changing to/from auth provider - carvel: description support - carvel: support changing auth type Bug fixes to support update support in UI: - auth updates were not possible - fixed conditions for fields enablement - form fields data were sent incorrectly as a group, instead of only sending what applied - errors handling 'undefined' values - fixed which auth types are valid per plugin+type combination - fixed issue with helm plugins image pull secrets helm/flux bug fixes: - fixed handling of redacted fields leading to secrets not being updated as expected or secret data being overwritten with 'redacted' as value. (note: the PR has many small changes, but i was fixing issues as i was testing, hence the list) ### Benefits With the changes, users should see more commonality between plugin features, as well as a more robust UI experience regarding repository creation/updates. ### Applicable issues fixes issues #5745, #5746 and #5747 ### Additional information The issue 1 in # 5746 could not be reproduce with the latest bits, so no change were made for it.
ppbaena
added
the
component/plugin-helm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
There are 2 bugs happening during a repository update with auth changes:
To Reproduce
Create a helm repository and configure auth credentials, pull image credentials and a tls CA.
issue 1:
Edit the helm repository, update the tls CA and save. Notice that the pull image secret is deleted, making the repository not readable anymore.
issue 2:
Edit the helm repository, update the tls CA and save. Notice that the auth secret is not updated with the new CA.
In fact, as long as one of the credentials remains "redacted", the other updates are ignored.
Expected behavior
issue 1: the pull image secret is not expected to be deleted when modifying the tls CA.
issue 2: users should be able to update only some of the credentials info (e.g. only the password) and expect the secret to be updated with what changed, retaining what was not changed
Desktop (please complete the following information):
kubeapps 12.1.1 / 2.6.1
The text was updated successfully, but these errors were encountered: