Update to support k8s 1.21 requiring dex update. #3066
Conversation
|
Oh, thanks for the change! I would have liked to address it when revamping the CI configuration for the multicluster env, but I didn't. AFAIK, you probably need to also change the circleci config. In fact, a CI check is failing. +1 when the CI also wants :P |
| @@ -415,11 +415,11 @@ install_multicluster_deps: &install_multicluster_deps | |||
| name: "Install multicluster deps" | |||
| command: | | |||
| sed -i -e "s/172.18.0.2/$DEFAULT_DEX_IP/g;s/localhost/kubeapps-ci.kubeapps/g" ./docs/user/manifests/kubeapps-local-dev-dex-values.yaml | |||
| helm repo add stable https://charts.helm.sh/stable | |||
| helm repo add dex https://charts.dexidp.io | |||
There was a problem hiding this comment.
After removing stable, we should also move openldap:
error: failed to download "stable/openldap" (hint: running helm repo update may help)
Edit: well, it seems there is no 'official' chart yet, so I would rather keep the 'stable` repo
There was a problem hiding this comment.
Yeah, I didn't want to try to change ldap. Just updated and fired off yesterday before moving onto something else, and forgot that we'll need stable still. It'll still fail after updating I expect as there's a new UI step in dex when logging in (giving consent to email being passed to 3rd party).
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
absoludity
removed
the
stale
absoludity
force-pushed
the
1.21-dev-env-support
branch
from
daf657f
to
917381e
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
antgamdia
removed
the
stale
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
1.21-dev-env-support
branch
from
917381e
to
94b2765
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Description of the change
I updated my local kind installation (to v0.11.1, so supporting k8s 1.21) only to find that it breaks the dev env.
The reason is a change in 1.21 which results in the version of dex we were using crash-looping.
Since we were using the deprecated (and no longer updated) stable repo for dex, I updated to the current dex chart repo and got things working with the latest version of that chart instead.
Benefits
Dev environment works with k8s 1.21.
Updated dex version (only visible difference is that it now lets the user choose to grant the email scope).
Possible drawbacks
None that I can think of.