Support multi-cluster with helm plugin #3282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR updates the GRPC registration function for plugins so that it receives the clusters configuration. This enables plugins to make decisions based on the clusters configuration, which is required for the Helm plugin as it behaves slightly differently for the cluster on which Kubeapps is installed.
Even though the Helm plugin only requires the kubeapps cluster name, I've passed the complete config for generality... perhaps we should just pass the kubeapps cluster name for now (though that makes assumptions about other plugins later needs).
It then updates the Helm plugin so that:
Example, after installing apache on the second cluster:
Benefits
We can continue to support the existing multicluster functionality when using the new API.
Possible drawbacks
Applicable issues
cluster
in packaging API #3278Additional information