Use dynamic current and latest versions in test #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
|
Rubber-stamping PR to unblock our ci pipeline |
|
Perhaps we should either increase the timeouts or add a waitFor .... "current". We are getting some erratic failures and I guess that's why they're due to. |
|
Thanks for picking that up when i left.
Yeah, short-term. We'd all prefer I'm sure to not have to guess and have deterministic tests, but we need to invest in that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Same purpose as #3432, but relying on selectors and pseudoselectors instead.
Triggering the CI to see if it works, if not, I'll debug in circleci cia ssh
Benefits
The CI test will no longer depend upon a fixed set of versions, but instead, it will get the
latestandlatest - 1to perform the upgrade.Possible drawbacks
It will mask issues like #3339, but we'd better go with this approach so that our CI doesn't get stuck in a permanent failure.
Applicable issues
Additional information
N/A