Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resources for assetsvc #3629

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fix resources for assetsvc #3629

merged 1 commit into from
Oct 21, 2021

Conversation

quarkie
Copy link
Contributor

@quarkie quarkie commented Oct 21, 2021

Description of the change

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! +1ing

However, the chart in this repo is just intended for development purposes. The "official" one is the one distributed by Bitami (https://github.com/bitnami/charts/tree/master/bitnami/kubeapps).
If you send the PR to their repo instead, the fix will be merged straight away and a new chart version will be released.

If doing the PR here, you'll have to wait until the next Kubeapps release, since it is when we sync the local chart changes with the upstream ones.

@antgamdia
Copy link
Contributor

Ah, also note that the assetsvc component will get deprecated soon. We are moving towards a package-system-agnostic and plugin-based approach. The current kubeapps version, indeed, is not using this component whatsoever.
Should you need more info about it, feel free to ping us in Slack :)

@quarkie
Copy link
Contributor Author

quarkie commented Oct 21, 2021

hi, thank you for the info :)

@antgamdia antgamdia merged commit baacaa9 into vmware-tanzu:master Oct 21, 2021
@quarkie quarkie deleted the patch-1 branch October 21, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants