Update the ResourceRef message with namespace. #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgamdia
approved these changes
Nov 19, 2021
absoludity
force-pushed
the
3779-add-namespace-to-ref
branch
from
cbfc108
to
3f33ab3
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3779-add-namespace-to-ref
branch
from
3f33ab3
to
21d63cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When beginning the UI/Dashboard work for getting resources, it was apparent that the existing code already handles the case where a resource for a helm deploy may not be in the same namespace as the helm release.
We had talked about this in the design doc and intended to update to support the same with the resource refs, but I'd missed this when implementing the backend.
This PR just updates to include the namespace in the resource ref for an installed package.
There will be one other small change to the backend implementation of the resources plugin which will follow.
Benefits
We don't remove support for this situation in the dashboard when switching to the new resources API.
Possible drawbacks
Applicable issues
Additional information