Third and final step of package repos API - Package Repository API for Helm #4807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
May 13, 2022 16:04
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
…-extra Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
…ations Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
castelblanque
commented
May 31, 2022
| @@ -26,7 +26,7 @@ type AppRepositorySpec struct { | |||
| Type string `json:"type"` | |||
| URL string `json:"url"` | |||
| Auth AppRepositoryAuth `json:"auth,omitempty"` | |||
| ResyncRequests uint `json:"resyncRequests"` | |||
| ResyncRequests int `json:"resyncRequests"` | |||
There was a problem hiding this comment.
Mentioned changed to the type of the existing CRD's ResyncRequests.
castelblanque
commented
May 31, 2022
| log.V(4).Infof("+helm upgrade repo %s customDetails [%v]", repoRef.Identifier, customDetails) | ||
| } | ||
|
|
||
| helmRepo := &HelmRepository{ |
There was a problem hiding this comment.
Using this custom HelmRepository to avoid having 8 parameters in functions signatures :)
antgamdia
approved these changes
Jun 1, 2022
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Third and final step on top of the second PR #4796.
This adds the following implementations and tests:
I had to change the original
AppRepositoryCR definition for the fieldResyncRequestsfrom typeuinttoint.Benefits
Package repository API is available for direct Helm plugin.
Possible drawbacks
I haven't seen any, but there might be misalignments in the
AppRepositoryCRDs data if both the old and this new API are used together over the same CRD. Due to the management of secrets, etc.However, this scenario could only happen during the transition time and should not happen in normal usage at all.
Applicable issues
Additional information
The reason for changing the data type in the original CRD was due to the k8s machinery
DeepCopyJSONValuebeing unable to handleuint(see here).