Update kubeappsapis and kubeops to support CA for pinniped-proxy #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
force-pushed
the
2268-pinniped-tls-2
branch
from
f249d0e
to
ee2141c
Compare
antgamdia
approved these changes
Jun 27, 2022
cmd/kubeops/cmd/root.go
Outdated
| @@ -65,6 +65,7 @@ func setFlags(c *cobra.Command) { | |||
| c.Flags().Int64Var(&serveOpts.Timeout, "timeout", 300, "Timeout to perform release operations (install, upgrade, rollback, delete)") | |||
| c.Flags().StringVar(&serveOpts.ClustersConfigPath, "clusters-config-path", "", "Configuration for clusters") | |||
| c.Flags().StringVar(&serveOpts.PinnipedProxyURL, "pinniped-proxy-url", "http://kubeapps-internal-pinniped-proxy.kubeapps:3333", "internal url to be used for requests to clusters configured for credential proxying via pinniped") | |||
| c.Flags().StringVar(&serveOpts.PinnipedProxyCACert, "pinniped-proxy-ca-cert", "", "Custom certificate authority to use with requests to pinniped-proxy service") | |||
There was a problem hiding this comment.
Can't recall right now, but, didn't we have a root.test.go file with a simple test adding each cmd argument? If so, it'd be great if we also add this param to the test.
There was a problem hiding this comment.
Yep, done, thanks.
absoludity
force-pushed
the
2268-pinniped-tls-2
branch
from
ee2141c
to
9dfad4c
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
2268-pinniped-tls-2
branch
from
1532feb
to
5962adc
Compare
✅ Deploy Preview for kubeapps-dev canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Following on from #4951 , this PR updates the clients of pinniped-proxy to support a CA cert to use when communicating with pinniped-proxy
Benefits
With this (and some chart changes, coming next), I'm able to configure communication with pinniped-proxy over TLS.
Possible drawbacks
Applicable issues
Additional information