Update chart to support TLS for pinniped-proxy #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgamdia
approved these changes
Jun 27, 2022
| @@ -1581,6 +1581,14 @@ pinnipedProxy: | |||
| ## @param pinnipedProxy.defaultPinnipedAPISuffix Specify the (default) API suffix | |||
| ## | |||
| defaultPinnipedAPISuffix: pinniped.dev | |||
| ## @param pinnipedProxy.TLSSecret Specify an optional TLS secret with which to proxy requests | |||
There was a problem hiding this comment.
I guess we have to run the readmenator to add those params to the chart docs.
There was a problem hiding this comment.
Yeah - I'll do that. It does now get run automatically upstream, but no need to wait.
There was a problem hiding this comment.
Yes, fortunately, there's no need anymore, but it's nice to have our chart up to date, especially if we, want to give a try to the brand new TLS config. Thanks!
absoludity
force-pushed
the
2268-pinniped-tls-2
branch
from
ee2141c
to
9dfad4c
Compare
absoludity
force-pushed
the
2268-pinniped-tls-3
branch
2 times, most recently
from
0729ef2
to
b0a4c4a
Compare
absoludity
force-pushed
the
2268-pinniped-tls-2
branch
from
1532feb
to
5962adc
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
2268-pinniped-tls-3
branch
from
b0a4c4a
to
3581d13
Compare
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Following on from #4958, this PR updates the kubeapps chart to:
Benefits
The pinniped-proxy service can run as a TLS web service, when configured so.
Possible drawbacks
Applicable issues
Additional information