Make ChartMuseum CI version configurable #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
commented
Jul 25, 2022
| @@ -27,6 +27,9 @@ parameters: | |||
| OLM_VERSION: | |||
| type: "string" | |||
| default: "v0.21.2" | |||
| CHARTMUSEUM_VERSION: | |||
| type: "string" | |||
| default: "3.9.0" | |||
There was a problem hiding this comment.
I'm also updating from 2.14.2 to 3.9.0 here, but I'll roll the changes back if the PR fails.
There was a problem hiding this comment.
It seems that it worked 😄
script/e2e-test.sh
Outdated
| @@ -17,6 +17,7 @@ TEST_TIMEOUT_MINUTES=${5:-"4"} | |||
| DEX_IP=${6:-"172.18.0.2"} | |||
| ADDITIONAL_CLUSTER_IP=${7:-"172.18.0.3"} | |||
| KAPP_CONTROLLER_VERSION=${8:-"v0.32.0"} | |||
| CM_VERSION=${9:-"2.14.2"} | |||
There was a problem hiding this comment.
Suggested change
| CM_VERSION=${9:-"2.14.2"} | |
| CHARTMUSEUM_VERSION=${9:-"3.9.0"} |
There was a problem hiding this comment.
Suggesting to change the variable name just for future readability.
script/e2e-test.sh
Outdated
| @@ -38,6 +39,7 @@ fi | |||
| info "Root dir: ${ROOT_DIR}" | |||
| info "Use multicluster+OIDC: ${USE_MULTICLUSTER_OIDC_ENV}" | |||
| info "OLM version: ${OLM_VERSION}" | |||
| info "ChartMuseum version: ${CM_VERSION}" | |||
There was a problem hiding this comment.
Suggested change
| info "ChartMuseum version: ${CM_VERSION}" | |
| info "ChartMuseum version: ${CHARTMUSEUM_VERSION}" |
script/e2e-test.sh
Outdated
| @@ -324,7 +328,7 @@ fi | |||
| installOrUpgradeKubeapps "${ROOT_DIR}/chart/kubeapps" | |||
| info "Waiting for Kubeapps components to be ready (local chart)..." | |||
| k8s_wait_for_deployment kubeapps kubeapps-ci | |||
| installChartmuseum admin password | |||
| installChartmuseum admin password "${CM_VERSION}" | |||
There was a problem hiding this comment.
Suggested change
| installChartmuseum admin password "${CM_VERSION}" | |
| installChartmuseum admin password "${CHARTMUSEUM_VERSION}" |
castelblanque
approved these changes
Jul 26, 2022
ppbaena
approved these changes
Jul 26, 2022
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
While working on the e2e tests I noticed we had a hardcoded CharMuseum version, this PR is extracting the version into a separate variable so that we can properly update it.
Benefits
CM cersion management will be aligned with the rest of the CI component's
Possible drawbacks
N/A
Applicable issues
Additional information
N/A