Refactored chart-museum logic for E2E tests #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2022 16:51
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 1555 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 758 | 1 | 796 | 0 |
Click to see the invalid file list
- script/chart-museum.sh
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
antgamdia
approved these changes
Aug 1, 2022
script/chart-museum.sh
Outdated
Comment on lines
6
to
10
| CM_PORT=${CM_PORT:-8090} | ||
| CM_USER=${CM_USER:-"admin"} | ||
| CM_PWD=${CM_PWD:-"password"} | ||
| CHART_MUSEUM_NS=${CHART_MUSEUM_NS:-"chart-museum"} | ||
| CM_VERSION=${CM_VERSION:-"3.9.0"} |
There was a problem hiding this comment.
As per #5119 (comment), I think we should use the same CHART_MUSEUM_ prefix, no?
There was a problem hiding this comment.
Yep, agree. Changed it to CHARTMUSEUM_ as in the e2e-test.sh file.
|
Thanks @antgamdia ! |
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This PR tackles two issues:
After Make ChartMuseum CI version configurable #5119 Charts museum version was upgraded. Parameters of the chart for user authentication have changed in the newer versions.
Previous version installation command
helm install chartmuseum --namespace chart-museum "https://github.com/chartmuseum/charts/releases/download/chartmuseum-3.8.0/chartmuseum-3.8.0.tgz" \ --set env.open.DISABLE_API=false \ --set persistence.enabled=true \ --set secret.AUTH_USER=admin \ --set secret.AUTH_PASS=passwordAuthentication was not working with newer version + old parameters. ChartMuseum could be accessed without any authentication:
kubectl run tmp-shell --restart=Never --rm -i --tty --image centos -- /bin/sh -c "curl http://chartmuseum.chart-museum.svc.cluster.local:8080/index.yaml"Newer versions installation command
helm install chartmuseum --namespace chart-museum "https://github.com/chartmuseum/charts/releases/download/chartmuseum-3.8.0/chartmuseum-3.8.0.tgz" \ --set env.open.DISABLE_API=false \ --set persistence.enabled=true \ --set env.secret.BASIC_AUTH_USER=admin \ --set env.secret.BASIC_AUTH_PASS=passwordScripting code used for managing ChartMuseum was mixed with the E2E code and scattered in a couple of files. This PR refactors that and keeps all ChartMuseum logic within a single file. It is also installed in its own namespace, instead of
kubeapps. The script can be used externally as a regular script, I mean apart from E2E.Benefits
Fix for authentication against ChartMuseum and tidier scripting code.
Possible drawbacks
N/A
Additional information