Added Helm global secret for namespaced repos #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2022 11:58
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
antgamdia
approved these changes
Aug 1, 2022
cmd/kubeapps-apis/plugins/helm/packages/v1alpha1/repositories.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com
Description of the change
This PR adds the handling of global secrets that affects to namespaced package repositories with secrets related.
Asset-syncer spings up the sync jobs in the global namespace and therefore it is requiring every namespace repo's secret to be copied to that location. Otherwise, private repos won't sync.
This management wasn't implemented yet in the new package repos API logic.
This wasn't, and isn't the best solution (cloning secrets into the global ns) but for now we have followed the same approach as in the old implementation.
Benefits
Repos controller can find now the secret for namespaced repositories in the global namespace.
Possible drawbacks
Maybe some edge cases not yet detected where repository controller needs the global secret? Can't think of any now.
Applicable issues