[Helm plugin] Changed repo secrets copied now to Kubeapps namespace

[castelblanque]

Signed-off-by: Rafa Castelblanque rcastelblanq@vmware.com

Description of the change

With the introduction of #5140, the secret for namespaced repos was being copied to the global namespace, which is incorrect.
The right one is the kubeapps namespace. Both are equal by default, but when apprepository.globalReposNamespaceSuffix is specified, syncer job runs in kubeapps namespace, and secrets are being created in the global namespace. This leads the syncer job creation to fail with error: Error: secret "test-apprepo-example-repo" not found.

This PR changes logic when creating and updating package repos so that secrets are copied to the kubeapps namespace if repo wasn't created in that namespace. In this way, we make sure that asset syncer has the secret available.

Benefits

Namespaced repos can be synced correctly now.

Possible drawbacks

We need to differentiate between global repos (in the Kubeapps global namespace, e.g. kubeapps-repos-global) and repos in kubeapps namespace (which might not be global).

Applicable issues

• fixes Added Helm global secret for namespaced repos #5140
• fixes Repos API/Helm - Support global private repos #5129

Additional information

This bug was found to be the origin of the problem mentioned in this comment of 5115.

[netlify]

✅ Deploy Preview for kubeapps-dev canceled.

Name	Link
🔨 Latest commit	69597cd
🔍 Latest deploy log	https://app.netlify.com/sites/kubeapps-dev/deploys/62f24be24a0651000872ce53

[antgamdia]

Great!! Thanks for catching the error and finding a solution. Just a question: what would happen when updating a repo? Is the secret also being updated in the kubeapps ns?

[castelblanque]

what would happen when updating a repo? Is the secret also being updated in the kubeapps ns?

Yes, secret will be created/overwritten with the new one, if any. You can see it here.