Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unavailable plugins in repo form #5252

Merged
merged 9 commits into from
Sep 6, 2022
Merged

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR uses the getConfiguredPlugins endpoint to disable those unavailable plugins when adding a repo from the UI.

Benefits

Users will only be able to add repos from an enabled plugin (today, an error is thrown)

Possible drawbacks

N/A

Applicable issues

Additional information

Example:

image

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to have now a better UX experience for users, with less unexpected errors. Thanks!

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Base automatically changed from get-plugins-from-server to main September 6, 2022 09:56
@antgamdia antgamdia merged commit 9538ec8 into main Sep 6, 2022
@antgamdia antgamdia deleted the disable-repo-unavail-plugin branch September 6, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make getPluginByName be plugin-aware
3 participants