Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases and minor fixes on the form parms #5548

Merged
merged 18 commits into from
Oct 24, 2022
Merged

Add test cases and minor fixes on the form parms #5548

merged 18 commits into from
Oct 24, 2022

Conversation

antgamdia
Copy link
Contributor

@antgamdia antgamdia commented Oct 21, 2022 •
edited
Loading

Description of the change

Once each of the PRs of the series related to this milestone has been merged, this final one is adding/fixing the test cases: adding new ones for the functionality we've added and fixing others. Besides, some minor fixes have been added (which have been discovered with the unit tests :P)

Benefits

Tests will pass now.

Possible drawbacks

N/A

Applicable issues

Additional information

Note
This PR is part of a series of PRs aimed at closing this milestone.
PR 6 out of 6

Edit: existing e2e tests are also failing :S, will have a look at them next week.

@antgamdia
Decode yamlseq/yamlmap to js objects
88d4ac3 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Support more json schema annotations
002f162 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Unify validations in sliderParam
8b46619 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Add new param rederers
87e606a 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Merge branch '1-3535-customSchema' into 2-5519-yamlDecodingFix
644660d
@antgamdia
Merge branch '2-5519-yamlDecodingFix'
6142082 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>

Conflicts:
	dashboard/src/shared/schema.ts
@antgamdia
Merge branch '3-5525-schemaAnnotations' into 4-5520-fixNumValidation
58a006e
@antgamdia
Merge branch '4-5520-fixNumValidation' into 5-5436-addSchemaRenderers
92ac5fe
@antgamdia
Merge branch 'main' into 6-formImpr-tests
411145d
@antgamdia
Fix slider param tests
2ff8e3b 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix array param tests
db3949a 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix param tests
e47a4ae 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix remaining tests
a0e52b6 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Fix type error in test
37d5c1d 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Merge branch '1-3535-customSchema'
8c8a277 
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>

Conflicts:
	dashboard/src/components/DeploymentForm/DeploymentFormBody/BasicDeploymentForm/TabularSchemaEditorTable/Params/ArrayParam.tsx
	dashboard/src/components/DeploymentForm/DeploymentFormBody/BasicDeploymentForm/TabularSchemaEditorTable/Params/BooleanParam.tsx
	dashboard/src/components/DeploymentForm/DeploymentFormBody/BasicDeploymentForm/TabularSchemaEditorTable/Params/SliderParam.tsx
	dashboard/src/components/DeploymentForm/DeploymentFormBody/BasicDeploymentForm/TabularSchemaEditorTable/Params/TextParam.tsx
	dashboard/src/components/DeploymentForm/DeploymentFormBody/BasicDeploymentForm/TabularSchemaEditorTable/TabularSchemaEditorTableRenderer.tsx
	dashboard/src/shared/utils.ts
@antgamdia
Revert "Merge branch '1-3535-customSchema'"
c6b9eb3 
This reverts commit 8c8a277.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia
Merge branch 'main' into 6-formImpr-tests
97b6969
@antgamdia antgamdia changed the base branch from 1-3535-customSchema to main October 21, 2022 17:05
@antgamdia antgamdia changed the base branch from main to 1-3535-customSchema October 21, 2022 17:06
absoludity
absoludity approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antgamdia antgamdia merged commit 0a3ae45 into 1-3535-customSchema Oct 24, 2022
@antgamdia antgamdia deleted the 6-formImpr-tests branch October 24, 2022 07:48
absoludity pushed a commit that referenced this pull request Feb 24, 2023
@dependabot
Bump axios from 1.3.3 to 1.3.4 in /integration (#6019)
f490a56 
Bumps [axios](https://github.com/axios/axios) from 1.3.3 to 1.3.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/releases">axios's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.3.4</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>blob:</strong> added a check to make sure the Blob class is
available in the browser's global scope; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5548">#5548</a>)
(<a
href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li>
<li><strong>http:</strong> fixed regression bug when handling
synchronous errors inside the adapter; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5564">#5564</a>)
(<a
href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+38/-26
([#5564](axios/axios#5564) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg"
title="+4/-0 ([#5548](axios/axios#5548)
)">lcysgsg</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan"
title="+3/-0 ([#5444](axios/axios#5444)
)">Michael Di Prisco</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">1.3.4</a>
(2023-02-22)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>blob:</strong> added a check to make sure the Blob class is
available in the browser's global scope; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5548">#5548</a>)
(<a
href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li>
<li><strong>http:</strong> fixed regression bug when handling
synchronous errors inside the adapter; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5564">#5564</a>)
(<a
href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+38/-26
([#5564](axios/axios#5564) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg"
title="+4/-0 ([#5548](axios/axios#5548)
)">lcysgsg</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan"
title="+3/-0 ([#5444](axios/axios#5444)
)">Michael Di Prisco</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/axios/axios/commit/2e70cecda42993e1153248f0f96715c3c55f7f39"><code>2e70cec</code></a>
chore(release): v1.3.4 (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5565">#5565</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/cbe2de60d3c9f494b4f5996632107d7a3a93abf1"><code>cbe2de6</code></a>
chore(ci): remove team-reviewers config; (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5566">#5566</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/2b1fc73600f28028499aa08c7baff980da10b504"><code>2b1fc73</code></a>
chore(docs): added missing config.transport doc (<a
href="https://github-redirect.dependabot.com/axios/axios/issues/5444">#5444</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a"><code>3772c8f</code></a>
fix(blob): added a check to make sure the Blob class is available in the
brow...</li>
<li><a
href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451"><code>a3b246c</code></a>
fix(http): fixed regression bug when handling synchronous errors inside
the a...</li>
<li>See full diff in <a
href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.3.3&new-version=1.3.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
absoludity pushed a commit that referenced this pull request Mar 16, 2023
@dependabot
Bump axios from 1.3.3 to 1.3.4 in /dashboard (#6092)
a3f1bdf 
Bumps [axios](https://github.com/axios/axios) from 1.3.3 to 1.3.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/releases">axios's
releases</a>.</em></p>
<blockquote>
<h2>Release v1.3.4</h2>
<h2>Release notes:</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>blob:</strong> added a check to make sure the Blob class is
available in the browser's global scope; (<a
href="https://redirect.github.com/axios/axios/issues/5548">#5548</a>)
(<a
href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li>
<li><strong>http:</strong> fixed regression bug when handling
synchronous errors inside the adapter; (<a
href="https://redirect.github.com/axios/axios/issues/5564">#5564</a>)
(<a
href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+38/-26
([#5564](axios/axios#5564) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg"
title="+4/-0 ([#5548](axios/axios#5548)
)">lcysgsg</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan"
title="+3/-0 ([#5444](axios/axios#5444)
)">Michael Di Prisco</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/axios/axios/blob/v1.x/CHANGELOG.md">axios's
changelog</a>.</em></p>
<blockquote>
<h2><a
href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">1.3.4</a>
(2023-02-22)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>blob:</strong> added a check to make sure the Blob class is
available in the browser's global scope; (<a
href="https://redirect.github.com/axios/axios/issues/5548">#5548</a>)
(<a
href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a">3772c8f</a>)</li>
<li><strong>http:</strong> fixed regression bug when handling
synchronous errors inside the adapter; (<a
href="https://redirect.github.com/axios/axios/issues/5564">#5564</a>)
(<a
href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451">a3b246c</a>)</li>
</ul>
<h3>Contributors to this release</h3>
<ul>
<li><!-- raw HTML omitted --> <a
href="https://github.com/DigitalBrainJS" title="+38/-26
([#5564](axios/axios#5564) )">Dmitriy
Mozgovoy</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/lcysgsg"
title="+4/-0 ([#5548](axios/axios#5548)
)">lcysgsg</a></li>
<li><!-- raw HTML omitted --> <a href="https://github.com/Cadienvan"
title="+3/-0 ([#5444](axios/axios#5444)
)">Michael Di Prisco</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/axios/axios/commit/2e70cecda42993e1153248f0f96715c3c55f7f39"><code>2e70cec</code></a>
chore(release): v1.3.4 (<a
href="https://redirect.github.com/axios/axios/issues/5565">#5565</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/cbe2de60d3c9f494b4f5996632107d7a3a93abf1"><code>cbe2de6</code></a>
chore(ci): remove team-reviewers config; (<a
href="https://redirect.github.com/axios/axios/issues/5566">#5566</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/2b1fc73600f28028499aa08c7baff980da10b504"><code>2b1fc73</code></a>
chore(docs): added missing config.transport doc (<a
href="https://redirect.github.com/axios/axios/issues/5444">#5444</a>)</li>
<li><a
href="https://github.com/axios/axios/commit/3772c8fe74112a56e3e9551f894d899bc3a9443a"><code>3772c8f</code></a>
fix(blob): added a check to make sure the Blob class is available in the
brow...</li>
<li><a
href="https://github.com/axios/axios/commit/a3b246c9de5c3bc4b5a742e15add55b375479451"><code>a3b246c</code></a>
fix(http): fixed regression bug when handling synchronous errors inside
the a...</li>
<li>See full diff in <a
href="https://github.com/axios/axios/compare/v1.3.3...v1.3.4">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=axios&package-manager=npm_and_yarn&previous-version=1.3.3&new-version=1.3.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absoludity absoludity absoludity approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antgamdia @absoludity @vmwclabot