Fix reopened website a11y issues #5579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
added a commit
that referenced
this pull request
Oct 28, 2022
### Description of the change This PR is a hotfix for a bug introduced at #5579: the searchbox init code was moved to a `static` folder, which is unable to retrieve the values from the site params. Therefore, the API key is literally `.Site.Params.docs_search_api_key` instead of the replaced value. Also, squeezing a minor fix to prevent `Kubeapps Kubeapps ...` to appear in the descriptions. ### Benefits Search will work again ### Possible drawbacks N/A ### Applicable issues N/A ### Additional information N/A Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR aims at fixing the remaining a11y issues that were reopened. Details at #5397 (comment)
Summary of the changes:
Benefits
a11y compliance
Possible drawbacks
N/A
Applicable issues
Additional information
This PR is based on top of #5578, as I assume it will get merged soon.
Also, I've removed some unused files (images mainly) and unified the icons we are using (ie, using the SVG ones, and resizing them, via CSS, instead of having several logos for the same purpose)
EDIT: there are more issues to solve I've just seen, will add the fixes to this PR