Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump libs to K8s 1.30 #1921

Merged
merged 11 commits into from
Apr 30, 2024
Merged

Bump libs to K8s 1.30 #1921

merged 11 commits into from
Apr 30, 2024

Conversation

joshuatcasey
Copy link
Member

@joshuatcasey joshuatcasey commented Apr 20, 2024

Bump libs to K8s 1.30.

@joshuatcasey joshuatcasey force-pushed the jtc/use-k8s-1.30 branch 2 times, most recently from 024a4ac to f927405 Compare April 23, 2024 01:59
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.45%. Comparing base (b99da0c) to head (9d21bca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
- Coverage   38.45%   29.45%   -9.00%     
==========================================
  Files         350      350              
  Lines       44680    58538   +13858     
==========================================
+ Hits        17182    17244      +62     
- Misses      26983    40779   +13796     
  Partials      515      515              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr cfryanr force-pushed the jtc/use-k8s-1.30 branch 3 times, most recently from e64c889 to 696d84f Compare April 26, 2024 17:46
@cfryanr
Copy link
Member

cfryanr commented Apr 26, 2024

I added 1.30 to the verify-codegen CI job and it failed with this error on the 1.30 codegen:

generating API-related code for our public API groups...
gen-api > ERROR: generate-groups.sh has been removed.
gen-api > ERROR: Please use k8s.io/code-generator/kube_codegen.sh instead.

So that's another item on the TODO list for this PR.

Reverting the commit (https://github.com/vmware-tanzu/pinniped-ci/commit/a7f342b81ca625d9ad2fea4ca38afb6ada7055e4) for now, but we need to figure out how to bring it back.

Update: I think I fixed this in the most recent commits.

@cfryanr
Copy link
Member

cfryanr commented Apr 26, 2024

This PR is also failing this integration test in CI about 50% of the time. This needs investigation during this PR effort.

=== FAIL: pkgname TestIntegrationParallel/TestLeaderElection_Parallel/clients_handle_leader_election_restart_correctly (30.02s)
    leaderelection_test.go:207: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln - current leader identity: leader-election-client-rxc9w, valid leader identities: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    leaderelection_test.go:207: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln - current leader identity: leader-election-client-rxc9w, valid leader identities: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    leaderelection_test.go:200: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln does not exist
    leaderelection_test.go:200: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln does not exist
    leaderelection_test.go:200: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln does not exist
    leaderelection_test.go:207: lease leader-election-k7tln-integration-test-tfp89/leader-election-k7tln - current leader identity: leader-election-client-rxc9w, valid leader identities: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    leaderelection_test.go:61: 
        	Error Trace:	/work/test/integration/leaderelection_test.go:307
        	            				/work/test/integration/leaderelection_test.go:61
        	Error:      	Should be zero, but was 1
        	Test:       	TestIntegrationParallel/TestLeaderElection_Parallel/clients_handle_leader_election_restart_correctly
        --- FAIL: TestIntegrationParallel/TestLeaderElection_Parallel/clients_handle_leader_election_restart_correctly (30.02s)

=== FAIL: pkgname TestIntegrationParallel/TestLeaderElection_Parallel (271.17s)
    leaderelection_test.go:41: running leader election client tests with 4 clients: [leader-election-client-9ltzb leader-election-client-dvhtm leader-election-client-rxc9w leader-election-client-v4sgc]
    client.go:811: cleaning up test namespace leader-election-k7tln-integration-test-tfp89
    --- FAIL: TestIntegrationParallel/TestLeaderElection_Parallel (271.17s)

Update: I added a potential fix for this problem to this PR. See below.

@cfryanr cfryanr force-pushed the jtc/use-k8s-1.30 branch 3 times, most recently from 85cf5c7 to 2f8d025 Compare April 29, 2024 19:29
@cfryanr cfryanr marked this pull request as ready for review April 30, 2024 21:33
@joshuatcasey
Copy link
Member Author

lgtm as of 9d21bca but I can't approve since I'm the PR author.

@cfryanr cfryanr merged commit 56d7dee into main Apr 30, 2024
42 checks passed
@cfryanr cfryanr deleted the jtc/use-k8s-1.30 branch April 30, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants