only auto-detect version v1 of ValidatingAdmissionPlugin during startup #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
=======================================
Coverage 29.39% 29.39%
=======================================
Files 350 350
Lines 58519 58518 -1
=======================================
+ Hits 17202 17203 +1
+ Misses 40802 40800 -2
Partials 515 515 ☔ View full report in Codecov by Sentry. |
joshuatcasey
reviewed
May 4, 2024
cfryanr
force-pushed
the
admission_plugins_need_v1
branch
from
e9f7075
to
85e5970
Compare
joshuatcasey
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1921.
CI showed that in an AKS 1.29 cluster which had version
v1beta1ofadmissionregistration.k8s.io, Pinniped would fail because the new 1.30 Kube libraries are specifically trying to start a watch forv1of this resource.This PR changes our new auto-detection code to specifically look for
v1, and to only enable the validating admission plugin whenv1is found.Release note: