Circle CI tests migration to GitHub Actions #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonehusin
changed the title
added 3 commits
January 5, 2021 13:49
Signed-off-by: Wilson E. Husin <whusin@vmware.com>
Signed-off-by: Wilson E. Husin <whusin@vmware.com>
Signed-off-by: Wilson E. Husin <whusin@vmware.com>
wilsonehusin
changed the title
| - uses: actions/checkout@v2 | ||
| - name: run tests | ||
| run: | | ||
| SONOBUOY_CLI=../../build/linux/amd64/sonobuoy ./scripts/run_integration_tests.sh |
There was a problem hiding this comment.
What's going on here? Is the sonobuoy binary taking script as param ? Or should the script generate something that sonobuoy can consume as param?
There was a problem hiding this comment.
that's the path to the Sonobuoy binary, so that the script can find where the newly built binary is (since it's not in $PATH)
https://github.com/vmware-tanzu/sonobuoy/blob/master/Makefile#L158-L161
There was a problem hiding this comment.
LoL. Oh jee. Yesterday was distracting. Oh man.
| - uses: actions/checkout@v2 | ||
| - name: run tests | ||
| run: | | ||
| SONOBUOY_CLI=../../build/linux/amd64/sonobuoy ./scripts/run_integration_tests.sh |
There was a problem hiding this comment.
LoL. Oh jee. Yesterday was distracting. Oh man.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Moving off Circle CI to have less service dependencies. End user / product should not be impacted.
Which issue(s) this PR fixes
Partially #1178
Special notes for your reviewer:
Release note: