Add e2e-repo-config flag to images pull command #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes M. Scheuermann <joh.scheuer@gmail.com>
johscheuer
force-pushed
the
enable-e2e-registry-image-pull
branch
from
5d276e1
to
dcece01
Compare
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
+ Coverage 42.91% 42.92% +0.01%
==========================================
Files 71 71
Lines 4162 4163 +1
==========================================
+ Hits 1786 1787 +1
Misses 2270 2270
Partials 106 106
Continue to review full report at Codecov.
|
zubron
approved these changes
Jun 27, 2019
There was a problem hiding this comment.
Thanks @johscheuer for raising this issue and submitting a fix! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Most of the background is described here: #780
TLDR: I would like to enable the --e2e-repo-config flag for the sonobuoy images pull command to validate that all required images are in place.
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: