Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make webhook probes less agressive #378

Merged
merged 2 commits into from
Mar 2, 2022
Merged

make webhook probes less agressive #378

merged 2 commits into from
Mar 2, 2022

Conversation

KauzClay
Copy link
Member

Fixes #356

Proposed Changes

  • 馃悰 Fix bug
  • follow pattern used in knative serving to use increased failure threshold and an initial delay on liveness/readiness probes.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs for any user-facing impact

Release Note

[Bug Fix]: readiness/liveness probes are now more patient when checking for the Webhook to be ready.

@KauzClay
make probes less agressive
3788bf6 
* follow pattern used in knative serving to use increased failure threshold and an initial delay
@KauzClay KauzClay requested a review from a team as a code owner February 23, 2022 22:33
@gabo1208 gabo1208 merged commit d6f5cf9 into vmware-tanzu:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabo1208 gabo1208 gabo1208 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Webhook liveness probe is too aggressive
2 participants
@KauzClay @gabo1208