Skip to content

Commit

Permalink
make webhook probes less agressive (#378)
Browse files Browse the repository at this point in the history
* make probes less agressive

* follow pattern used in knative serving to use increased failure threshold and an initial delay

* add comment explaining change
  • Loading branch information
KauzClay committed Mar 2, 2022
1 parent 673a216 commit d6f5cf9
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion config/webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ spec:
value: webhook

readinessProbe: &probe
periodSeconds: 1
# Increasing the failure threshold and adding an initial delay
# avoids the situation where failing probes cause the webhook to restart before it can
# finish setup. See https://github.com/vmware-tanzu/sources-for-knative/issues/356
failureThreshold: 6
initialDelaySeconds: 20
httpGet:
scheme: HTTPS
port: 8443
Expand Down

0 comments on commit d6f5cf9

Please sign in to comment.