Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests when using upstream vcsim #454

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Jul 8, 2022

Closes: #453
Signed-off-by: Michael Gasch 15986659+embano1@users.noreply.github.com

Fixes #

Proposed Changes

  • 馃Ч remove default vcsim container image logic in E2E since this is not needed with latest vcsim image anymore (in fact was broken too, but unnoticed due to E2E using ko by default)

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs for any user-facing impact

Release Note


Closes: vmware-tanzu#453
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
@embano1 embano1 marked this pull request as ready for review July 8, 2022 09:23
@embano1 embano1 requested a review from a team as a code owner July 8, 2022 09:23
@embano1 embano1 changed the title chore: Fix E2E tests when using upstream vcsim Fix E2E tests when using upstream vcsim Jul 8, 2022
@gabo1208 gabo1208 merged commit 9da3260 into vmware-tanzu:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultVcsimImage not needed anymore
2 participants