fix: load AWS config and assume role #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisdavim
force-pushed
the
fix_aws_creds
branch
3 times, most recently
from
1011a64
to
bd10b15
Compare
Codecov Report
@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 17.48% 17.86% +0.38%
==========================================
Files 6 6
Lines 652 638 -14
==========================================
Hits 114 114
+ Misses 532 518 -14
Partials 6 6
|
luisdavim
force-pushed
the
fix_aws_creds
branch
from
bd10b15
to
7d6981a
Compare
3 tasks
luisdavim
force-pushed
the
fix_aws_creds
branch
2 times, most recently
from
028993d
to
e0fc0d0
Compare
reasonerjt
approved these changes
Aug 7, 2023
reasonerjt
requested changes
Aug 7, 2023
There was a problem hiding this comment.
I see an error when I patch the plugin with this change and test with IRSA
...
sg="Error getting backup store for this location" backupLocation=velero/default controller=backup-sync error="rpc error: code = Unknown desc = AccessDenied: User: arn:aws:sts::822276436757:assumed-role/eksctl-jt-velero-irsa-addon-iamserviceaccoun-Role1-1T470KOHYLTBK/1691417499559809485 is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::822276436757:role/eksctl-jt-velero-irsa-addon-iamserviceaccoun-Role1-1T470KOHYLTBK\n\tstatus code: 403, request id: 9e390336-c55f-4dd0-9d34-ec8233945ab6" error.file="/go/src/velero-plugin-for-aws/velero-plugin-for-aws/volume_snapshotter.go:67" error.function=main.getSession logSource="pkg/controller/backup_sync_controller.go:100"
Signed-off-by: Luis Davim <dluis@vmware.com>
luisdavim
force-pushed
the
fix_aws_creds
branch
from
e0fc0d0
to
6953c8c
Compare
That looks like the role is being assumed twice, I guess the SDK is handling that for us now and the extra assume role is not needed, I've updated the PR, can you run that test again? Thanks. |
reasonerjt
approved these changes
Aug 8, 2023
blackpiglet
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes vmware-tanzu/velero#3142
Please also have a look at vmware-tanzu/velero#6598